Feature/add net9 net10 support #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 12, 2026 14:09
Introduced a new `IKcOrganizations` interface and its implementation in `KcOrganizations` to enable CRUD operations, listing, and filtering of organizations in Keycloak. Updated the `IKeycloakClient` and `KeycloakClient` classes to expose the `Organizations` client. Added supporting models: - `KcOrganization` to represent organization resources. - `KcOrganizationDomain` to represent domain information. - `KcOrganizationFilter` to enable filtering options for queries. Updated `NETCore.Keycloak.Client.csproj` to clean up formatting and remove unnecessary metadata files.
Updated XML documentation for `KcOrganization`, `KcOrganizationDomain`, and `KcOrganizationFilter` to improve clarity and align with Keycloak API references. Added `<value>` tags for property descriptions. Refactored `KcOrganizationFilter`: - Replaced multiple filtering properties with a generic `Q` property. - Updated `Exact` property to indicate exact match behavior. - Switched from `System.Text.Json` to `Newtonsoft.Json` for serialization. - Rewrote `BuildQuery` for cleaner and more maintainable query string construction. Improved consistency in naming conventions and descriptions across classes. Removed redundant properties and comments. Aligned code structure with Keycloak API standards.
Updated `IKcOrganizations` interface and `KcOrganizations` implementation to enhance XML documentation, align with the latest Keycloak REST API, and improve maintainability. - Added `using` directives for required dependencies in `IKcOrganizations.cs`. - Updated XML documentation for all methods in `IKcOrganizations` to include detailed return type descriptions and exception handling details. - Replaced outdated Keycloak API links in `KcOrganization` and `KcOrganizationDomain` with updated references. - Used `<inheritdoc>` tags in `KcOrganizations` to ensure consistency with the interface and reduce redundancy. - Implemented methods in `KcOrganizations` with improved documentation and alignment with the updated interface.
Updated `TargetFrameworks` in both `NETCore.Keycloak.Client.Tests.csproj` and `NETCore.Keycloak.Client.csproj` to include `net9.0` and `net10.0`. Introduced framework-specific dependency management using conditional `ItemGroup` sections to ensure proper versioning for each target framework. Updated several dependencies, including `Newtonsoft.Json` (13.0.3 → 13.0.4) and `System.IdentityModel.Tokens.Jwt` (8.3.0 → 8.15.0). Removed redundant dependencies and adjusted formatting for consistency. Removed the `Cake` package reference from the test project.
Updated string manipulation logic to use the range operator for trailing slash removal in `KeycloakClient` and `KcHttpClientBase`. Refactored `NETCore.Keycloak.Client.Tests.csproj` to adjust formatting and added `PasswordGenerator` dependency. Enhanced `NETCore.Keycloak.Client.csproj` by reorganizing package references for target frameworks, adding `Newtonsoft.Json`, and including metadata files in the package. Updated `NoWarn` settings to suppress additional warnings. These changes improve code consistency, dependency management, and project configuration.
Author
|
I think we should remove support for .NET 6 and .NET 7 to simplify the codebase and align with currently supported .NET versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.