Repository navigation
Custom obs and command formats for the CS API - #45
Closed
tipatterson-dev wants to merge 7 commits into
Closed
tipatterson-dev wants to merge 7 commits into
tipatterson-dev wants to merge 7 commits into
Conversation
… schemas Extend the CustomObsFormat SPI with command-side hooks (getCommandBinding, getCommandSchemaBinding) and an isAutoSelectable flag, and thread the configured customFormats map through the obs, command, command-status, datastream-schema and command-stream-schema handlers so a registered format (e.g. application/swe+proto) can serve its own data and schema views.
… POST Dispatch datastream and control-stream creation to a registered custom format's binding when the embedded schema names it. DataStreamBindingJson gains a custom-format branch ahead of the application/swe+ prefix match; CommandStreamBindingJson buffers the schema object and dispatches on commandFormat, staying backward-compatible (a missing commandFormat still uses the default JSON binding); CommandStreamHandler threads the customFormats map through to the binding.
…es from alternate transports
Author
|
Superseded by #46 (branch renamed to feat/consys-custom-formats). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets addon modules plug custom encodings (e.g.
application/swe+proto,application/swe+flatbuffers) into the Connected Systems API for observations, commands and their schemas. Needed by the federation/MQTT work in osh-addons (fed-service-pr-cleanup).Changes
CustomObsFormat: datastream schema and obs bindings,isAutoSelectableso a format can be listed without being auto-picked for browsers.CustomCommandFormat: command stream schema and command bindings. One class can implement both;ConSysApiServiceregisters each configured class for whichever it implements.formats, like datastreams.RequestContext(servlet, URI, OutputStream)for one-shot GETs from other transports.f=; transports (MQTT) now pass their:data/<format>token asf=instead of pre-setting the context format.Same work as opensensorhub#354, with all of the review comments there addressed.
Testing
sensorhub-service-consystests pass; full core suite passes except a flaky threaded SensorML test (TestSMLProcessing.testReadAndExecNestedChainsWithThreads) that passes when rerun.swe+protoobs and command schemas over HTTP and MQTT; two-node federation with the counter sim driver, commands sent to the commander over HTTP and MQTT ran on the remote.