Skip to content

feat: add close button to widget and fix Storybook v10 config #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KARTIK-PANDEY-KP merged 3 commits into from
Mar 10, 2026
Merged

feat: add close button to widget and fix Storybook v10 config #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09b1892
feat: add close button to widget and fix Storybook v10 config
KARTIK-PANDEY-KP Mar 10, 2026
423a3ab
fix: remove redundant backgrounds.default in favour of initialGlobals
KARTIK-PANDEY-KP Mar 10, 2026
1a7ffb2
fix: use dark overlay for close button hover to work on all header co…
KARTIK-PANDEY-KP Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .storybook/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,26 @@ import '../src/styles/variables.css';

const preview: Preview = {
parameters: {
actions: { argTypesRegex: '^on[A-Z].*' },
controls: {
matchers: {
color: /(background|color)$/i,
date: /Date$/i,
},
},
backgrounds: {
options: {
light: { name: 'light', value: '#f5f5f5' },
dark: { name: 'dark', value: '#1a1a2e' },
white: { name: 'white', value: '#ffffff' }
}
values: [
{ name: 'light', value: '#f5f5f5' },
{ name: 'dark', value: '#1a1a2e' },
{ name: 'white', value: '#ffffff' },
],
},
},

initialGlobals: {
backgrounds: {
value: 'light'
}
}
value: '#f5f5f5',
},
},
};

export default preview;
Expand Down
1 change: 1 addition & 0 deletions src/components/ChatWidget/ChatWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
useEffect(() => {
hasLoadedConfig.current = false;
fetchConfig();
}, [embedId, mockMode, apiClient]);

Check warning on line 136 in src/components/ChatWidget/ChatWidget.tsx

View workflow job for this annotation

GitHub Actions / build 

React Hook useEffect has a missing dependency: 'fetchConfig'. Either include it or remove the dependency array

// Effective config: base config + prop overrides (updates instantly without re-fetch)
const effectiveConfig = useMemo((): DeploymentConfig => {
Expand Down Expand Up @@ -325,6 +325,7 @@
onStartChat={handleStartChat}
onNavigate={handleNavigate}
currentPage="home"
onClose={isInline ? undefined : handleClose}
/>
) : (
<ChatContainer
Expand Down
40 changes: 40 additions & 0 deletions src/components/HomePage/HomePage.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,52 @@
z-index: 1;
}

.headerTopRow {
display: flex;
align-items: center;
justify-content: space-between;
}

.agentInfo {
display: flex;
align-items: center;
gap: var(--bb-spacing-md);
}

.closeButton {
width: 32px;
height: 32px;
border-radius: var(--bb-radius-full);
background: rgba(0, 0, 0, 0.1);
border: none;
cursor: pointer;
display: flex;
align-items: center;
justify-content: center;
color: var(--bb-header-text-color, var(--bb-text-inverse));
transition: background var(--bb-transition-fast), transform var(--bb-transition-fast);
flex-shrink: 0;
}

.closeButton:hover {
background: rgba(0, 0, 0, 0.2);
transform: scale(1.05);
Comment thread
KARTIK-PANDEY-KP marked this conversation as resolved.
}

.closeButton:active {
transform: scale(0.95);
}

.closeButton:focus-visible {
outline: 2px solid rgba(255, 255, 255, 0.5);
outline-offset: 2px;
}

.closeButton svg {
width: 18px;
height: 18px;
}

.headerLogo {
width: 42px;
height: 42px;
Expand Down
38 changes: 30 additions & 8 deletions src/components/HomePage/HomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export interface HomePageProps {
onStartChat: () => void;
onNavigate: (page: 'home' | 'messages') => void;
currentPage: 'home' | 'messages';
onClose?: () => void;
}

export const HomePage: React.FC<HomePageProps> = ({
Expand All @@ -24,6 +25,7 @@ export const HomePage: React.FC<HomePageProps> = ({
onStartChat,
onNavigate,
currentPage,
onClose,
}) => {
const handleHomeCardClick = () => {
if (homeLink) {
Expand All @@ -36,15 +38,35 @@ export const HomePage: React.FC<HomePageProps> = ({
<div className={styles.header}>
<div className={styles.headerBackground} />
<div className={styles.headerContent}>
<div className={styles.agentInfo}>
{agentLogoUrl ? (
<img src={agentLogoUrl} alt={agentName} className={styles.headerLogo} />
) : (
<div className={styles.headerLogoPlaceholder}>
<BrainbaseLogo className={styles.headerBrainbaseLogo} color="white" cutoutColor="var(--bb-primary-color)" />
</div>
<div className={styles.headerTopRow}>
<div className={styles.agentInfo}>
{agentLogoUrl ? (
<img src={agentLogoUrl} alt={agentName} className={styles.headerLogo} />
) : (
<div className={styles.headerLogoPlaceholder}>
<BrainbaseLogo className={styles.headerBrainbaseLogo} color="white" cutoutColor="var(--bb-primary-color)" />
</div>
)}
<span className={styles.headerAgentName}>{agentName}</span>
</div>
{onClose && (
<button
className={styles.closeButton}
onClick={onClose}
aria-label="Close chat"
type="button"
>
<svg viewBox="0 0 24 24" fill="none">
<path
d="M6 18L18 6M6 6L18 18"
stroke="currentColor"
strokeWidth="2"
strokeLinecap="round"
strokeLinejoin="round"
/>
</svg>
</button>
)}
<span className={styles.headerAgentName}>{agentName}</span>
</div>
</div>
</div>
Expand Down
Loading