Don't error out if chown fails and avoid manually escaping quotes#38
Merged
BretFisher merged 2 commits intoBretFisher:mainfrom Mar 31, 2026
Merged
Don't error out if chown fails and avoid manually escaping quotes#38BretFisher merged 2 commits intoBretFisher:mainfrom
BretFisher merged 2 commits intoBretFisher:mainfrom
Conversation
chown may fail when the destination file system doesn't support Unix ownership attributes. Since the success of chown isn't critical, if this happens, just print a warning and continue.
4570f10 to
864f375
Compare
There was a problem hiding this comment.
Pull request overview
Updates vackup export to treat chown failures as non-fatal so exports succeed on filesystems that don’t support Unix ownership attributes (e.g., exFAT), aligning behavior with issue #37.
Changes:
- Wrap
chownduringexportso a failure prints a warning and does not fail the overall export. - Preserve export success message and exit code even when ownership change can’t be applied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
this avoids any issues with escaping quotes
Contributor
Author
|
Linter failed on Dockerfile, in other words, unrelated to the PR. |
Owner
|
Thanks, and sorry I sat on this for so long. |
Contributor
Author
Nah, no worries at all, I've been using my own modified copy, the whole point of FOSS 😋 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chown may fail when the destination file system doesn't support Unix ownership attributes. Since the success of
chownisn't critical, if this happens, just print a warning and continue.Fixes #37
Demo:
Before this PR:
After this PR:
Edit: Added 2nd commit, which passes variables to the Docker container as environmental variables and expands them inside the container. This avoids manually escaping quotes, which may fail if the file name contains a single/double quote character.