Repository navigation
use identity engine cookie for passwordless - #532
Conversation
| // DSSO can sometimes take more than one attempt. Both this terminal page and the | ||
| // transient Agentless DSSO page have "Sign In" titles, so only retry from this path. | ||
| if( url.AbsolutePath.Equals( "/oauth2/v1/authorize", StringComparison.OrdinalIgnoreCase ) ) { |
There was a problem hiding this comment.
In my browser dev tool I'm not seeing this URL as the terminal page.
I suspect you were seeing some race conditions. IIUC, page loads/refreshes don't wait for await in this event handler OnPageLoadAsync, so you could be seeing "sign in" title from a later loaded page but with URL from an earlier page?
There was a problem hiding this comment.
/oauth2/v1/authorize returns a 302 with no body, so it can't have a title at all.
the terminal page is /login/agentlessDsso/idx?stateToken=...
There was a problem hiding this comment.
Hmm yea I guess we are maybe killing the attempt too early then since when we see that url we retry? I can see where it ends up. That probably would only help with debugging though since this url (seemingly?) only gets hit off vpn?
Probably a small amount of time but is there an other reason to not exit as early as we could if we know the attempt won't work? I didn't do this deliberately though since that original text check was already there so I'm down for whatever. I am not sure about the title though - maybe it's a Puppeteer thing?
Attempting Okta passwordless authentication...
Launching browser: C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe
Creating new browser tab
Navigating to https://d2l.okta.com/
Browser loaded https://d2l.okta.com/app/UserHome with title ''
Browser loaded https://d2l.okta.com/oauth2/v1/authorize with title 'D2L Corporation - Sign In'
Attempt 1 failed. Retry...
Browser loaded https://d2l.okta.com/oauth2/v1/authorize with title 'D2L Corporation - Sign In'
Attempt 2 failed. Retry...
Browser loaded https://d2l.okta.com/oauth2/v1/authorize with title 'D2L Corporation - Sign In'
Okta passwordless authentication is not available
| if( BmxEnvironment.IsDebug ) { | ||
| messageWriter.WriteWarning( $"Browser loaded {page.Url}" ); | ||
| messageWriter.WriteWarning( | ||
| $"Browser loaded {url.GetLeftPart( UriPartial.Path )} with title '{title}'" |
There was a problem hiding this comment.
I assume this is to hide the query string which can contain somewhat sensitive parameters?
would be good to include a comment explaining this
2 participants
Why
Add a bandaid fix for BMX to support Okta Identity Engine along with the Classic Engine
Ticket
VUL-3855 - BMX > Stopgap for auto login failure