[raldone01]

• Expose windows file attributes.
• Mirror std FileType Debug impl.

Also cool to see #[must_use] littered in a code base for once. I think rust should really make all types must use by default. Hopefully they will do it in a future edition. I think it should be opt-out rather than opt-in. I mean rust already has the very nice _ and it makes functions that return something obvious.

[raldone01]

@Byron thanks for merging. Btw why did you change the Debug impls? I copied them exactly from the rust std lib.

[Byron]

Yes, they are changed to be more concise.

[raldone01]

It's fine.

#[stable(feature = "std_debug", since = "1.16.0")]
impl fmt::Debug for FileType {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        f.debug_struct("FileType")
            .field("is_file", &self.is_file())
            .field("is_dir", &self.is_dir())
            .field("is_symlink", &self.is_symlink())
            .finish_non_exhaustive()
    }
}

I was also surprised rust picked the above for the std Debug impl.

[raldone01]

Also I am curious why gate it behind unstable? Rust std has stable support for file_attributes on windows: https://doc.rust-lang.org/std/os/windows/fs/trait.MetadataExt.html#tymethod.file_attributes

Will this become stable or is it just because it is a feature that is platform specific? I am pretty sure windows might add flags but they will never remove/change existing ones.

[Byron]

The method is unstable because I don't want to commit to it forever.
And yes, on Windows with junctions there might dir symlinks and file symlinks, so the Rust version of the debug impl is probably less degenerating. I'd recommend keeping the current version, and instead go with something like FileType(LINK|DIR) if it's a dir link on Windows. Feel free to submit a PR for that.

[raldone01]

Makes sense. I think all changes work fine for my use case. Thanks for cutting a release.