-
Notifications
You must be signed in to change notification settings - Fork 1.5k
IO: write_PLY() for Epeck #7874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
BGL tests failing in CGAL-6.0-Ic-112 |
|
Successfully tested in CGAL-6.0-Ic-116 |
|
@afabri There is still an undone TODO in the top message of this other PR. Do you want this PR merged as it is? |
No, I still want to fix the generic code. |
|
@afabri any chance you can fix that today (if inclusion in 5.6.1 is needed)? |
|
@afabri, this PR was marked tested 2 month ago and is still waiting for a TODO. Maybe you want to open an issue instead and integrate the PR. |
|
Ping @afabri |
Will be treated somewhere in the future. |
This comment was marked as outdated.
This comment was marked as outdated.
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7874/v0/Manual/index.html |
|
/force-build:v0 |
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7874/v0/Manual/index.html |
|
@afabri please resolve all conversations |
Co-authored-by: Mael <[email protected]>
|
Successfully tested in CGAL-6.2-Ic-39 |
Summary of Changes
As reported in #7868 the function
CGAL::IO::write_PLY()used in binary mode does not correctly write the coordinates if the points are from a kernel with exact constructions.This PR applies `to_double()" to the coordinates.After a discussion with @MaelRL we decided that the user is in charge to pass avertex_point_mapas named parameter that does the conversion. This is straightforward as we offer theCartesian_converter_property_map.Moving back to the previous proposal: hardcode some to_double and to_float casts such that we meet the requirements of the file format, whatever the input.
As the problem is the same for the vertex normals we add a named parameter
vertex_normal_map.Todo
write_polygon_mesh(). Currently it is fixed forSurface_meshRelease Management