Skip to content

Conversation

@afabri
Copy link
Member

@afabri afabri commented Nov 20, 2023

Summary of Changes

As reported in #7868 the function CGAL::IO::write_PLY() used in binary mode does not correctly write the coordinates if the points are from a kernel with exact constructions.
This PR applies `to_double()" to the coordinates.

After a discussion with @MaelRL we decided that the user is in charge to pass a vertex_point_map as named parameter that does the conversion. This is straightforward as we offer the Cartesian_converter_property_map.

Moving back to the previous proposal: hardcode some to_double and to_float casts such that we meet the requirements of the file format, whatever the input.

As the problem is the same for the vertex normals we add a named parameter vertex_normal_map.

Todo

  • Fix the generic function write_polygon_mesh(). Currently it is fixed for Surface_mesh

Release Management

@sloriot
Copy link
Member

sloriot commented Nov 22, 2023

BGL tests failing in CGAL-6.0-Ic-112

@sloriot sloriot added Tests failing Batch_1 First Batch of PRs under testing and removed Under Testing labels Nov 22, 2023
@sloriot sloriot added Under Testing and removed Tests failing Batch_1 First Batch of PRs under testing labels Nov 22, 2023
@sloriot
Copy link
Member

sloriot commented Nov 29, 2023

Successfully tested in CGAL-6.0-Ic-116

@lrineau
Copy link
Member

lrineau commented Nov 29, 2023

@afabri There is still an undone TODO in the top message of this other PR. Do you want this PR merged as it is?

@afabri
Copy link
Member Author

afabri commented Nov 29, 2023

@afabri There is still an undone TODO in the top message of this other PR. Do you want this PR merged as it is?

No, I still want to fix the generic code.

@sloriot
Copy link
Member

sloriot commented Dec 14, 2023

@afabri any chance you can fix that today (if inclusion in 5.6.1 is needed)?

@sloriot
Copy link
Member

sloriot commented Jan 24, 2024

@afabri, this PR was marked tested 2 month ago and is still waiting for a TODO. Maybe you want to open an issue instead and integrate the PR.

@lrineau lrineau modified the milestones: 5.6.1, 5.6.2 Feb 28, 2024
@lrineau
Copy link
Member

lrineau commented May 28, 2024

Ping @afabri

@afabri
Copy link
Member Author

afabri commented May 28, 2024

Ping @afabri

Will be treated somewhere in the future.

@afabri

This comment was marked as outdated.

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7874/v0/Manual/index.html

@afabri
Copy link
Member Author

afabri commented Sep 30, 2025

/force-build:v0

@github-actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7874/v0/Manual/index.html

@sloriot
Copy link
Member

sloriot commented Oct 17, 2025

@afabri please resolve all conversations

@sloriot sloriot removed Not yet approved The feature or pull-request has not yet been approved. TODO labels Nov 13, 2025
@sloriot
Copy link
Member

sloriot commented Nov 13, 2025

Successfully tested in CGAL-6.2-Ic-39

@sloriot sloriot merged commit dfc5fb5 into CGAL:main Nov 13, 2025
9 checks passed
@sloriot sloriot deleted the IO-read_PLY_Epeck-GF branch November 13, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Writing a binary PLY file does not work with an EPECK mesh

4 participants