Thumbnail generator: read preset list from presetTextures.js - #108
Open
boinger wants to merge 1 commit into
Open
Thumbnail generator: read preset list from presetTextures.js#108boinger wants to merge 1 commit into
boinger wants to merge 1 commit into
Conversation
generate_thumbs.py hardcoded the same 24 filenames as IMAGE_PRESETS; adding a texture required editing both. Parse the url: fields instead; fail loudly if none parse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_thumbs.pyduplicates the 24-texture filename list fromIMAGE_PRESETSinjs/presetTextures.js, so adding a texture means editing both files (and forgetting the second means a missing thumbnail).Parse the
url:fields frompresetTextures.jsinstead — adding a texture there is now the only edit needed. Fails loudly if the format ever changes rather than silently generating nothing.Verified: the parsed list matches the previous hardcoded list exactly (24/24), and every referenced file exists in
textures/.