Fix: Arrival status condition - #187
Closed
kathryntanardy wants to merge 1 commit into
Closed
kathryntanardy wants to merge 1 commit into
kathryntanardy wants to merge 1 commit into
Conversation
Contributor
|
This will need to be investigated more and we'll see if we even need to fix it. A bus is marked "Arrived" when:
The important bit is number 2, since we're dependent on TransLink's realtime data to mark them correctly. I'm not exactly sure when they decide a bus has begun going the opposite direction, but the only other option would be to get bus position data and make a box around the upper loop, which would reduce the number of updates we can fetch by 50%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #186
Fix for the TransLink bus status logic so buses are only marked Arrived once their realtime departure time has passed, with a 60-second grace window. Future buses now remain Delayed or OnTime based on delay.