Add Bus Widget Modal - #57
Open
kathryntanardy wants to merge 12 commits into
Open
Conversation
jbriones1
requested changes
Sep 4, 2026
jbriones1
requested changes
Sep 6, 2026
| export class BusDepartureCardComponent { | ||
| readonly departure = input.required<DepartureInfo>(); | ||
|
|
||
| readonly delaySeconds = input.required<number>(); |
Contributor
There was a problem hiding this comment.
Can probably just infer this from the departure object and reduce the number of inputs down to 1. Not sure if I'm missing something, but when it's used in the template you just supply departure.delaySeconds anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for replacing the hidden dropdown in the bus schedule widget with a full modal view. The bus widget still shows the next departure on the main screen. When a route is clicked, it now opens a modal with the next departure and the upcoming departures for that route.
Changes: