Skip to content

Conversation

@benwilson512
Copy link
Member

No description provided.

@benwilson512
Copy link
Member Author

Thoughts @LostKobrakai ?

@LostKobrakai
Copy link
Contributor

I generally like it. The typespec would need updating though.

Also I'd skip the arity-1 callback option. If we introduce the new version of ecto Repo.transaction does pass the repo to both multi and functions passed in. So I'd go for fn aggregate, repo -> or fn aggregate, repo, changes ->. I feel this is nearer to ecto, where at least for multi usage repo is also passed all the time.

@benwilson512
Copy link
Member Author

benwilson512 commented Jan 28, 2020

That's fair, can you elaborate on use of changes? I'm not sure I see when it would be used.

@LostKobrakai
Copy link
Contributor

It‘s the changes provided by Ecto.Multi.run and ….merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants