[pull] master from MusicPlayerDaemon:master#58
Merged
pull[bot] merged 12 commits intoCartoonFan:masterfrom Feb 9, 2026
Merged
Conversation
Whilst trying to build (on Windows), the incorrect `base` prevented it from building.
…API breakage This avoids MPD build breakages for users which have libupnp with the API-breaking commit pupnp/pupnp@25d4bd0 We once had the conditional `const` loooong ago, but it was removed by commit 736a696 ("drop support for libupnp versions older than 1.8"). I don't want to add another compile-time conditional because I don't understand the API change yet. I'm not even sure anybody even uses MPD with UPnP. Let's see if anybody complains (and re-submits the old pre-1.8 workaround, but I'd prefer if the pupnp project reverts the API breakage instead). See pupnp/pupnp#528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )