Refactorings 24#3274
Merged
Merged
Conversation
rscipien
reviewed
Apr 29, 2026
| // then | ||
| assertThat( | ||
| roleAssignments.stream().map(RoleAssignment::getId).collect(toList()), | ||
| ssignments.stream().map(RoleAssignment::getId).collect(toList()), |
Contributor
There was a problem hiding this comment.
Typo ssignments -> assignments
| public Dataset getDatasetByHarvestInfo(final Long dataverseId, | ||
| final String harvestIdentifier) { | ||
| final List<Dataset> list = em.createQuery( | ||
| final List<Dataset> list = createQuery( |
Contributor
There was a problem hiding this comment.
Maybe we this string concatenation in sql could be replaced with named parameters
rscipien
approved these changes
Apr 30, 2026
added 6 commits
April 30, 2026 12:04
…h .isEmpty() since getStringFromNonDefaultBundle never return null extracted method, added test
lbownik
force-pushed
the
refactorings_24
branch
from
d881f4f to
5387245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.