3276 clone a dataset#3278
Conversation
| xmlns:ui="http://java.sun.com/jsf/facelets" | ||
| xmlns:p="http://primefaces.org/ui" | ||
| xmlns:c="http://xmlns.jcp.org/jsp/jstl/core" | ||
| xmlns:jsf="http://xmlns.jcp.org/jsf" xmlns:o="http://omnifaces.org/ui" |
There was a problem hiding this comment.
Could be in new line xmlns:o="http://omnifaces.org/ui"
|
|
||
| } | ||
|
|
||
| private void copyVieldValuesFromSourceDataset() { |
There was a problem hiding this comment.
Typo copyVieldValuesFromSourceDataset
| groupAndUpdateFlagsForEdit(datasetFields, this.dataset.getOwner().getMetadataBlockRootDataverse()); | ||
|
|
||
| if(this.sourceDatasetId != null) { | ||
| copyVieldValuesFromSourceDataset(); |
There was a problem hiding this comment.
Why cloning is inside resetDatasetFields?
Looks like reset method hide this cloning functionality
There was a problem hiding this comment.
so that is works with data set template mechanism, a user cloning dataset can selet a template on dataset creation page that also contains predefined field values. then new dataset values are fielst powied form template and then optioanlly overwritten by values from cloned dataset.
There was a problem hiding this comment.
resetDatasetFields(); is invoked tom init() in line 226 and from updateSelectedTemplate(..) in line 240
| @@ -0,0 +1,95 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Maybe this files should be named cloneDatasetDialog?
There was a problem hiding this comment.
this dialog has been used to create dataset so far, and has been repurposed to also enable cloning which is a creation operation as well so ... let's leave the name.
lbownik
force-pushed
the
3276_clone_a_dataset
branch
from
a24f129 to
be3d909
Compare
2 participants
https://git.icm.edu.pl/dariah/archeo/-/work_items/259