Closes #3279 Investigate nullPointerExcetion from log#3280
Merged
Conversation
prevented logging unsupported image format as error - this is normal situation
madryk
approved these changes
May 8, 2026
| } | ||
| if(fullSizeImage != null) { | ||
| final int width = fullSizeImage.getWidth(null); | ||
| final int height = fullSizeImage.getHeight(null); |
Collaborator
There was a problem hiding this comment.
It is fine. However IMO it would be easier to read if we would have:
if (fullSizeImage != null) {
return false;
}
final int width = fullSizeImage.getWidth(null);
final int height = fullSizeImage.getHeight(null);
...
return true;
I will let you decide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevented logging unsupported image format as error - this is normal situation