Closes #3287 Change zip file name for bulk downloads#3288
Merged
Conversation
rscipien
reviewed
May 15, 2026
|
|
||
| private String createFileName(final String authorName, final Timestamp datasetCreationTime) { | ||
|
|
||
| final String publicationYear = new SimpleDateFormat("YYY").format(datasetCreationTime); |
Contributor
There was a problem hiding this comment.
Format probably should have 4YYYY
| Dataset dataset = findDatasetOrDie(datasetId); | ||
| publicationTime = dataset.getCreateDate(); | ||
| DatasetVersion datasetVersion = getDatasetVersionOrDie(dataverseRequest, versionId, dataset); | ||
| author = datasetVersion.getDatasetAuthors().get(0).getName().getRawValue(); |
Contributor
There was a problem hiding this comment.
Maybe if would be better to use stream and findFirst?
author = datasetVersion.getDatasetAuthors()
.stream()
.findFirst()
.map(author -> author.getName().getRawValue())
.orElse("Unknown");
rscipien
approved these changes
May 15, 2026
added 4 commits
May 15, 2026 11:03
lbownik
force-pushed
the
3287_Change_zip_file_name_for_bulk_downloads
branch
from
263488a to
1b1b789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.