Handle parsing of reports with no .Results list #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A trivy fs scan may have no .Results list if there are no manifests for it to process. This might happen with an empty directory, for example. This commit allows the report_generator.parse_results function to return None if there is no Results key in the report data. print_issue will test that the value returned by parse_results is not None before proceeding. Fixes CemitDigital#1.
report_generator.parse_results can return None, so handle this in report_issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trivy fs scan may have no .Results list if there are no manifests for
it to process. This might happen with an empty directory, for example.
This commit allows the report_generator.parse_results function to return
None if there is no Results key in the report data. print_issue will
test that the value returned by parse_results is not None before
proceeding.
Fixes #1.