[SVCS-479] Raise exception for copy/move replace folder that orphans itself. #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
See previous PR for discussion #274 |
NyanHelsing
force-pushed
the
ft/move-orphan-delete
branch
6 times, most recently
from
6318684 to
b2dcd9f
Compare
NyanHelsing
force-pushed
the
ft/move-orphan-delete
branch
from
4cd003d to
3dd4687
Compare
cslzchen
requested changes
May 29, 2018
Contributor
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
@birdbrained Thanks for the rebase 👍 and please fix travis 🔥 .
Fixing an issue where when a child component is hooked up To a project, and they share the same provider, it is possible to silently delete files
[#SVCS-479] Replace folder from inside folder deletes both Add replace_will_orphan(src_path,dest_path) Checks if dest_path overwrite will orphan src_path Call replace_will_orphan in copy/move defs in waterbutler.core.provider
SVCS-479 Move three pieces of overwrite conflict logic from move/copy into handle_naming and rename handle_naming to handle_conflict. Improved logic and reduced code.
There was some places where the http method 'get' was written in lowercase. this was changed to upper case to match the rest of the codebase, and broke some tests. This fixes those tests also.
Box's validate_v1_path http method name should be lowercase.
NyanHelsing
force-pushed
the
ft/move-orphan-delete
branch
from
0b546dc to
e012a51
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/SVCS-479
Replaces: #274
Purpose:
Replace folder from inside folder deletes both
Changes:
Side effects
Folder move/copies that use conflict=replace may now be more costly