-
Notifications
You must be signed in to change notification settings - Fork 8
Cleanup config files #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Cleanup config files #144
Conversation
|
@schnamo Could you please have a look if this makes sense to you or if I have removed anything important? |
|
One more fix: The |
I think the raw torch module for BCE loss will throw an error, as we pass some kwargs to forward method which is not accepted by it. Instead the config should use the wrapper from python-chebai/chebai/loss/bce_weighted.py Lines 108 to 111 in 395b5a8
|
|
Looks great, thank you Simon! |
schnamo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thank you
| filename=os.path.join( | ||
| self.data_extractor.processed_dir, file_name | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfluegel05
Passing complete file path causes following issue: https://wandb.ai/chebai/chebai/runs/pjql8wjk/logs?nw=nwuseraditya0by0
Passing just the file name causes the below issue
https://wandb.ai/chebai/chebai/runs/m5rgurmi/logs?nw=nwuseraditya0by0
|
Do we need to retain certain comments from PR #130? ... like below Lines 87 to 96 in 395b5a8
Lines 73 to 77 in 395b5a8
... |
We have a lot of config files that do different things which might be confusing to new users and lead to unexpected results. For example, the callback configs sometimes save a checkpoint every 25 epochs, sometimes they only save the last checkpoint. Sometimes, they save the best 3, sometimes only the best 1.
I tried to reduce the number of configs and find a consistent naming pattern. More precisely, I
weightingsdirectory andloss/weighting_chebi100.yml- those were all static lists of weights which are not needed anymore since those weights get calculated on the fly by the weighted BCE.binary_callbacks.ymlandearly_stop_callbacks_roc-auc.ymlsolCurandtox21callbacks (as far as I can tell, they are not specific to the dataset)solves #139