Allow copying to a S3 bucket directory. #12
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotek
approved these changes
May 25, 2022
| fi | ||
|
|
||
| aws s3 cp "$FILENAME".sql.gz s3://"$INPUT_AWS_S3_BUCKET" | ||
| if [ -z "${INPUT_AWS_S3_DIRECTORY}" ] ] |
Contributor
There was a problem hiding this comment.
Not familiar enough with how aws_s3_directory in config is translated into environment var INPUT_AWS_S3_DIRECTORY, but if that is how it works, then the code looks sane and clean.
Author
There was a problem hiding this comment.
I forget where I've found it before and a quick search didn't turn much up, but I'm following the pattern used elsewhere in this repo.
Good eye on the naming difference though. 🦅
Author
There was a problem hiding this comment.
If you want to use this, can you point the GH Action to this branch to give this a spin, then once we confirm it works for you, we can merge it?
- uses: chromatichq/db-backup-sync-action@sync-to-subfolder
I think this will do the trick. 🤞🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow copying to a S3 bucket directory.
Motivation / Context
Sometimes you want to use a single bucket and use folders within it.
Testing Instructions / How This Has Been Tested
TK.
Screenshots
TK
Documentation
Included. ✅