This repository was archived by the owner on Jun 2, 2026. It is now read-only.
Reject lexer errors during parse#70
Open
StantonMatt wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Stanton <stantonmatthewj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63.
parse("value =< 42")was succeeding because Chevrotain reported=as a lexer error, but the parser only received the remaining valid tokens and parsed the expression asvalue < 42. This now returns a parse failure whenever tokenization reports invalid characters, so lexer errors cannot be silently dropped before parsing.I also updated the existing newline-in-string expectations to assert the new lexer-error message instead of the previous parser EOF message.
Validation:
pnpm exec vitest src/spec/index.spec.ts --runfailed before the fix with the new regression and passed after the fixpnpm testpnpm lintpnpm type-checkpnpm buildgit diff --checkreview-fix-loopclean: no actionable correctness issues