Skip to content

Change weakptr uilist_iml in uilist to a sharedptr #83840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Change weakptr uilist_iml in uilist to a sharedptr #83840

wants to merge 2 commits into from
+11 −10

Conversation

@migo-chan
Copy link

@migo-chan migo-chan bot commented Nov 20, 2025

Summary

Bugfixes "Allow UI Scrolling and fix UI scroll bouncing"

Purpose of change

Backport of #83832. See that PR for details.

@CoreyHendrey
Change weakptr uilist_iml in uilist to a sharedptr
0922ec8 
If we pass "true" into qry
it will cause the uilist to loop until
input is detected, which stops the bouncing
because a new uilist_impl ISNT
created every frame. Instead, I changed
the weak_ptr to a shared_ptr so the uilist
has control of the the ui lifetime

fixes #82428
fixes #78783
reverts #82269
@CoreyHendrey
Updating comment
5471b7f
@migo-chan migo-chan bot mentioned this pull request Nov 20, 2025
Merged
@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 20, 2025
@kevingranade
Copy link
Member

kevingranade commented Nov 20, 2025

I'm not an expert at the imGUI integration but this applies cleanly and in the same way as the original PR, so it looks pretty low risk to me.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 21, 2025
RenechCDDA
RenechCDDA requested changes Nov 21, 2025
View reviewed changes
Copy link
Member

@RenechCDDA RenechCDDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#83848 and #83854 are very probably side effects, so I'm unsure we want to backport this as-is.

If we have a fix for the new issues we might want to backport this and then backport the fix "on top" just for ease of merging. But as is, this doesn't seem to be workable.

@GuardianDll
Copy link
Member

GuardianDll commented Nov 24, 2025 •
edited
Loading

If someone is willing, making a manual backport of #83832, #83856 and #83877 in one PR is okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RenechCDDA RenechCDDA RenechCDDA requested changes

Assignees

No one assigned

Labels

0.I-branch astyled astyled PR, label is assigned by github actions backport BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kevingranade @GuardianDll @RenechCDDA @CoreyHendrey