[Bugfix] Cosmetics not moved to new submap in EOC copy_location #83866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
ehughsbaird
reviewed
Nov 21, 2025
github-actions
bot
added
the
BasicBuildPassed
Contributor
|
is your Flying House something that could be incorporated into the game? As something for Magiclysm maybe? |
Contributor
Author
The current interior design leans more towards alien technology products, but your idea sounds great. I can actually redesign the Flying House to be more aligned with a magical world aesthetic. |
zephyrflow
force-pushed
the
fix/cosmetics_not_included_in_copy_location
branch
from
8c92bae to
9a2fee7
Compare
github-actions
bot
added
the
Map / Mapgen
zephyrflow
force-pushed
the
fix/cosmetics_not_included_in_copy_location
branch
from
9a2fee7 to
d44a99d
Compare
ehughsbaird
approved these changes
Nov 22, 2025
Contributor
ehughsbaird
left a comment
ehughsbaird
left a comment
There was a problem hiding this comment.
It is odd that these only take a subset of the submap data, but this looks like the correct place to put this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Cosmetics not moved to new submap in EOC copy_location"
Purpose of change
I created a cold storage room in the Flying House with a low-temperature warning sign at the door. After a teleport, I realized the sign's message couldn't be read. I tested further by drawing a graffito, which remained behind after teleportation. I have now fixed this bug.
Describe the solution
In the code of EOC 'copy_location', move signage and graffiti to new submap, since their positions are stored in point_sm_ms, cosmetics do not require location updates.
Describe alternatives you've considered
No other alternative solutions have been identified so far.
Testing
Following the code fix, a teleport test with the Flying House was conducted. Results showed the graffiti was successfully moved and the cold storage warning sign functioned normally. A check of the original location confirmed that the original instances of both the graffito and sign were successfully cleared.
Additional context
Flying House is a Mod I developed, It is just like Vanishing Arc of Aftershock that you can teleport with the ship.