Skip to content

Conversation

@PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Remove usage of redundant active transformation field in favor of SPAWN_ACTIVE on active items.

Describe the solution

Remove the redundant field and add the flag.

Describe alternatives you've considered

Testing

Debug spawned each of the active and inactive items and transformed them to verify it worked, with exceptions and notes under Additional context.

Additional context

  • The UPS units in the mod should be updated to distinguish between on and off status (has been done in the base game).
  • A number of active versions of items were given the "ARTIFACT" type matching the base item, as debug spawed items wouldn't display the same otherwise.
  • Couldn't test exo_AR_module, as I could find no way to power it to allow it to be turned on.
  • The atomic smartphone music was bugged. Transformed into itself when turned off. Fixed.
  • Wratheon phone name changed for lit version. Fixed.
  • VR glasses: Why is the active holo stuff artifact, but not the base laptop? This causes the debug spawned item to display differently (and possibly behave differently). Overall, it appears item conversion doesn't create subtypes. I leave this for the maintainers to sort out.
  • CE-4: Why isn't it compatible with reusable light batteries (which was the ones I debug spawned to try to power it before finding it's not compatible)?

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Melee Melee weapons, tactics, techniques, reach attack Mods: Aftershock Anything to do with the Aftershock mod Items: Armor / Clothing Armor and clothing labels Nov 22, 2025
@PatrikLundell PatrikLundell removed the request for review from Maleclypse November 22, 2025 11:46
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant