-
Notifications
You must be signed in to change notification settings - Fork 6
[SDK-5246] Adds Gif Support #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| } | ||
| } | ||
| } else { | ||
| self.showAltImageView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Bug
The alternative GIF loading path inconsistently pre-validates GIF URLs using CTUtiltiy.checkImageUrlValid before sd_setImage. This utility may not correctly handle GIFs, potentially rejecting valid URLs and causing unnecessary fallback to regular images. This pre-validation is also redundant, as sd_setImage includes its own error handling.
akashvercetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xcodeproj isnt building cuz SDWebImage isn't included in the libraries section with the "do not embed" flag. Manual integration and xcframework generation will fail
|
@nishant-clevertap I think the command |
Note
Adds GIF rendering to notification templates using SDWebImage, introducing new
pt_gif(andpt_gif_alt) fields with graceful fallback to static images.SDWebImage(podspec dependency) and vendor framework; switch image views toSDAnimatedImageViewwhere needed.CTCaptionedImageView: newisGifSupportedflag; usessd_setImagefor GIFs, existing loader for static images.pt_gifwhen available; fallback topt_big_img/product images; keep manual/auto carousel static images as before.pt_gif; post-expiry supportspt_gif_alt; fallbacks to image variants; accessibility labels maintained.pt_gifor fallback topt_big_img.pt_gifor fallback topt_big_img.isGifSupported: false(no change in behavior).pt_giftoCarouselProperties,RatingProperties,ZeroBezelProperties.pt_gif,pt_gif_alt(and related alt-text fields) toTimerTemplateProperties.CTNotificationContentExample.xcscheme).Written by Cursor Bugbot for commit ecc47f2. This will update automatically on new commits. Configure here.