Add the possibility to use the Veros ocean model as the ocean component in ClimaOcean #602
Conversation
|
I think this is ready to merge. We probably have to tweak the extension again after https://github.com/nutrik/veros/tree/atm_coupling is merged into main, and we have space where to fill in salt and temperature flux. |
|
@simone-silvestri looks like this is a bit stale, is there a possibility of refreshing it? The interesting exercise here is to couple veros and SpeedyWeather I think now that we have the SpeedyWeather extension. |
| v :: CF | ||
| T :: CC | ||
| S :: CC | ||
| end |
There was a problem hiding this comment.
is it not possible to use a general exchanger? Do we need special exchangers for each component?
|
|
||
| s = [] | ||
| tx = [] | ||
| ty = [] |
There was a problem hiding this comment.
why can't you use a regular JLD2Writer? I think that would be preferred, to illustrate the user interface which is important.
| taux = view(parent(net_ocean_fluxes.u), 1:nx, 1:ny, 1) .* ρₒ | ||
| tauy = view(parent(net_ocean_fluxes.v), 1:nx, 1:ny, 1) .* ρₒ | ||
|
|
||
| # TODO: Do not do this 12 thingy when we can make sure |
| setup = @eval $setups.$setup_name() | ||
|
|
||
| # instantiate the setup | ||
| setup.setup() |
There was a problem hiding this comment.
is setup the best name for this object, given that it has a method called setup()? Perhaps the function setup() should be something like instantiate() so it's out of our control...
This is an exploratory PR to use ClimaOcean to force a veros setup.
This exercise is also usefull to make sure that ClimaOcean does not necessarily assume that the ocean model comes from Oceananigans but it is flexible enough to handle different ocean configurations.