-
Notifications
You must be signed in to change notification settings - Fork 254
Support ImmersedBoundaryGrid reconstruction using NetCDF
#4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
One thing that's making this harder is the fact that we started flattening singleton dimensions in NetCDF output. For example, while a 2D I wonder if it's worth going back on that decision and keeping singleton dimensions. @ali-ramadhan @glwagner thoughts? |
|
If it makes the source code simpler, I vote for keeping the third dimension. In the end, Oceananigans' fields are always three-dimensional. |
|
I think it makes sense to keep singleton dimensions in NetCDF output if it simplifies the interface between NetCDF and Oceananigans. I think the disadvantages are minor. If we can identify significant disadvantages in the future, then we can motivate investing energy into supporting the removal of singleton dimensions later. |
Another necessary step towards supporting
FiedTimeSeriesconstruction from NetCDF output