Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Oceananigans community, I am fairly new here and I am interested in building my simulations and contribution skills with the Oceananigans package. I have opened a discussion post here and an issue here, with idea of implementing a basic lock-exchange problem. My goal is to use this case to deepen my understanding of computational fluid dynamics, boundary conditions, and density-driven mixing. My ideal outcome is to produce a fully documented example script that meets the standards of the existing examples.
I have opened this PR with a very basic version which includes my current understanding of how to run the simulations. I will happily welcome any and all feedback for any changes or ideas that would help me build on this existing script to make it a worthwhile contribution. So far, I have pulled from the internal tide example as well as the lock release validation case, and I will continue to build on what I have so far.
Thank you in advance for your time and help!