Skip to content

History view: relative last-N-days links and From/To date pickers - #3445

Open
Algunenano wants to merge 4 commits into
ClickHouse:mainfrom
Algunenano:history-last-days
Open

Algunenano wants to merge 4 commits into
ClickHouse:mainfrom
Algunenano:history-last-days

Conversation

@Algunenano

Copy link
Copy Markdown
Member

The history view only accepted absolute &from=/&to= dates, so a bookmarked link went stale. This adds &last=N, which shows the last N days relative to today, e.g. ...&history=clickhouse%2Fc8g.metal-48xl.json&last=15. The "Copy link" button keeps the relative parameter.

It also adds From/To date pickers to the history bar (an empty picker leaves that side open; dragging over the chart fills them), and the history link in the summary table now opens the last 15 days by default. "Show all dates" lifts the limit.

Algunenano and others added 2 commits November 19, 2026 13:39
`&last=N` shows the last N days, so a bookmarked link stays fresh
instead of pinning `from`/`to` dates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y default

The history link in the summary table now opens the last 15 days;
"Show all dates" lifts the limit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

@neuroalexey neuroalexey left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Please verify — the history icon opens an empty view for most entries

The history icon now opens the last 15 days (index.html:2061). But 835 of the 1421 entries in data.generated.js have no result on or after 2026-11-04. For them the view is empty and says "No results for this metric" (index.html:2100). For example, postgresql/c6a.4xlarge.json has its latest result on 2026-09-21. Is it expected?

Let's add &last= only when elem.date is inside the window (index.html:1546). Or fall back to all dates when the range is empty. The message is also wrong here: the metric has results, but the range has none.

I read the rest of the diff. &last= is restored from the URL and kept by Copy link, and an empty picker leaves its side open.

Optional, not blocking:

  • The machine links drop the range, so switching the machine shows all dates again (index.html:2014).

Automated review by neuroalexey

…ults

Otherwise most entries opened on an empty view. Also say "No results in
this date range" when only the range is empty.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@neuroalexey

Copy link
Copy Markdown

Status: Looks good — fixed in ec4ec75

index.html:1544 adds &last=15 only when the latest result is in the window. The 835 entries without a recent result now open on all dates.

Automated review by neuroalexey

@alexey-milovidov

Copy link
Copy Markdown
Member

I don't think we should show last 15 days by default. Looks arbitrary...

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

@Algunenano

Copy link
Copy Markdown
Member Author

I don't have a strong position. I don't think keeping all dates is scalable, but I don't mind. Changed back to full on the link. Kept the last=X which is the one I need

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants