Skip to content

🐛 fix(vm): memory leak in _stackFrameFreeList - #237

Open
SimonShiki wants to merge 2 commits into
feat/ts-vm-2from
fix/memory-leak-in-stack-frame
Open

🐛 fix(vm): memory leak in _stackFrameFreeList#237
SimonShiki wants to merge 2 commits into
feat/ts-vm-2from
fix/memory-leak-in-stack-frame

Conversation

@SimonShiki

@SimonShiki SimonShiki commented May 25, 2026

Copy link
Copy Markdown
Member

Requires #236

Description

Fix memory leak in _stackFrameFreeList, that holds target and not clear even the target get disposed.

Proposed Changes

  1. Make _StackFrame holds a weak ref for the target
  2. Clear _stackFrameFreeList when target disposed or runtime disposed.

Test Coverage

None

Additional Context

None

@SimonShiki
SimonShiki changed the base branch from dev/3.2 to feat/ts-vm-2 May 25, 2026 03:45
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 25, 2026

Copy link
Copy Markdown

Deploying clipcc-preview with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8920021
Status: ✅  Deploy successful!
Preview URL: https://105f3281.clipcc-preview.pages.dev
Branch Preview URL: https://fix-memory-leak-in-stack-fra.clipcc-preview.pages.dev

View logs

@SimonShiki
SimonShiki marked this pull request as ready for review May 25, 2026 06:33
@SimonShiki
SimonShiki force-pushed the fix/memory-leak-in-stack-frame branch 2 times, most recently from fea08ce to 2f1612b Compare August 11, 2026 03:33
@SimonShiki SimonShiki self-assigned this Aug 11, 2026
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
Signed-off-by: SimonShiki <sinangentoo@gmail.com>
@SimonShiki
SimonShiki force-pushed the fix/memory-leak-in-stack-frame branch from 2f1612b to 8920021 Compare August 14, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant