Skip to content

feat(js): export composable launchPersistentContext helpers - #405

Open
regseb wants to merge 1 commit into
CloakHQ:mainfrom
regseb:buildLaunchPersistentContextOptions
Open

regseb wants to merge 1 commit into
CloakHQ:mainfrom
regseb:buildLaunchPersistentContextOptions

Conversation

@regseb

@regseb regseb commented Jun 28, 2026

Copy link
Copy Markdown

Fix #241

Add buildLaunchPersistentContextOptions() and humanizeContext() helpers function.

This PR is a follow-up to the #244 and #262 PRs.

@regseb
regseb force-pushed the buildLaunchPersistentContextOptions branch from 7f758f9 to 131501c Compare June 29, 2026 06:58
@regseb
regseb force-pushed the buildLaunchPersistentContextOptions branch from 131501c to ccd62e1 Compare July 6, 2026 18:33
# Conflicts:
#	js/src/playwright.ts
#	js/tests/launch.test.ts

# Conflicts:
#	js/src/playwright.ts
@regseb
regseb force-pushed the buildLaunchPersistentContextOptions branch from ccd62e1 to 81ba0b3 Compare July 31, 2026 15:57
@regseb

regseb commented Jul 31, 2026

Copy link
Copy Markdown
Author

@Cloak-HQ Would it be possible for you to review my PR?

There are often other changes in js/src/playwright.ts. This causes conflicts that I have to resolve.

@Cloak-HQ
Cloak-HQ force-pushed the main branch 2 times, most recently from c8a7097 to 9fa2472 Compare August 7, 2026 21:18
@Cloak-HQ

Copy link
Copy Markdown
Member

Thanks for the PR. Before reviewing the API change, could you clarify the concrete use case? Is Playwright-ghost solving a specific limitation or failure you encountered with CloakBrowser’s current wrapper, or is the goal primarily architectural compatibility with its plugin system? If specific plugins are required, which ones and what capability do they provide that CloakBrowser currently lacks?

@regseb

regseb commented Aug 11, 2026

Copy link
Copy Markdown
Author

This PR is a follow-up to:

My PR completes these additions with buildLaunchPersistentContextOptions() and humanizeContext() for launchPersistentContext(). There are now methods to configure the parameters for all three launch*() methods and to humanize their return objects (Browser or Context).


Playwright-ghost adds a plugin system to Playwright. Plugins allow you to modify the input parameters and return values of methods. However, you cannot modify a method directly. That’s why I need the build*() and humanize*() methods.

Playwright-ghost and CloakBrowser have different goals. Playwright-ghost is more general-purpose with its plugins, while CloakBrowser is more focused on stealth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JS] Export function to only build options

2 participants