-
Notifications
You must be signed in to change notification settings - Fork 0
Separate styling from tsx components #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR converts inline CSS styles to Tailwind classes for several authentication-related components, removes unused files, and fixes test data structure to match the actual implementation.
Changes:
- Converted inline styles to Tailwind classes in
Login.tsx,Register.tsx, andRegisterLanding.tsx - Removed unused
Account.tsxandProfile.tsxfiles - Fixed test assertions in
GrantCalculations.test.tsxto match the actual data structure returned by the implementation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/Login.tsx | Removed inline style object and converted styles to Tailwind classes |
| frontend/src/Register.tsx | Removed inline style object and converted error/warning styles to conditional Tailwind classes |
| frontend/src/RegisterLanding.tsx | Removed inline style object and converted to Tailwind classes, added margin to button |
| frontend/src/Account.tsx | Deleted unused component file |
| frontend/src/Profile.tsx | Deleted unused component file |
| frontend/tests/GrantCalculations.test.tsx | Fixed test expectations to match implementation's data structure with nested data property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
….com/Code-4-Community/bcan into separate-styling-from-tsx-components
ℹ️ Issue
Closes #280
📝 Description
Login.tsx,Register.tsx, andRegisterLanding.tsx.Account.tsxandProfile.tsxfiles since they were unusedGrantCalculations.text.tsxto fix an error I was getting with the structure of the data.RegisterLanding.tsxfor a better look.✔️ Verification
N/A (pages look same as before)
Test Changes
N/A
🏕️ (Optional) Future Work / Notes
Register.tsx), the height of the page shortened a bit when I changed the styles to Tailwind, but it shouldn't be noticeable.