Repository navigation
Shell Sort in C#: .NET 10 and a copy-per-call benchmark - #2370
Merged
vladimir-pecanac-main merged 2 commits intoNov 13, 2026
Merged
vladimir-pecanac-main merged 2 commits into
vladimir-pecanac-main merged 2 commits into
Conversation
Both projects target net10.0 with BenchmarkDotNet 0.15.8 and MSTest 4.5.2. The benchmark moves into its own ShellSortBenchmarks class that copies the generated array before every sort, so each call measures unsorted input instead of the array the first call already sorted. ShellSort() drops the unused arrayName parameter, Program.cs passes args to BenchmarkRunner, and the tests use (expected, actual) order with two new cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves csharp-algorithms/ShellSort to net10.0 with BenchmarkDotNet 0.15.8, MSTest 4.5.2, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. The benchmark now lives in a ShellSortBenchmarks class that copies the generated array into a working array before every call, because the old benchmark sorted its ArgumentsSource arrays in place and every measured call timed already-sorted data. The sizes are powers of two (4,096, 16,384 and 65,536) so the imbalanced input is a real worst case for Shell's gaps. ShellSort() drops the unused arrayName parameter, Program.cs passes args to BenchmarkRunner, the tests use file-scoped namespaces and (expected, actual) order, and two tests are added: an empty array and generated arrays checked against Array.Sort.