Contact - Pipedrive #31
Conversation
|
PR looks ok to me. |
sanandnarayan
left a comment
sanandnarayan
left a comment
There was a problem hiding this comment.
can we have some way to have the js run only in the contact page. this is not urgent so we can do this correctly
| if(typeof window !== 'undefined') { | ||
| let userDetails = {} | ||
| let SITE_NAME = window.location.origin | ||
| document.getElementById('contact-form') && |
There was a problem hiding this comment.
@Kameshwaran should we put this in JS only in the contact page. in header.js means it will come in every page right?
There was a problem hiding this comment.
Let's keep it in the header.
This JS not only contains form handling logic, but also tracks the list of pages browsed by the visitor. That info also sent in the form when a visitor submits it.
|
may be the form logic should be a part of the form component , and not a part of the header template? |
sanandnarayan
requested review from
Kameshwaran
and removed request for
sanandnarayan
Replied here. |
src/pages/thank-you.js
Outdated
|
|
||
| const ThankYou = () => { | ||
| return ( | ||
| <CenteredDiv> |
There was a problem hiding this comment.
https://theme-ui.com/guides/layouts , can we use main component from https://theme-ui.com/guides/layouts instead of centered div
src/templates/header.js
Outdated
| const idea = document.getElementById('idea').value | ||
| const email = document.getElementById('email').value | ||
| document.getElementById('contact-submit').disabled = true | ||
| document.getElementById('idea').value = "" |
There was a problem hiding this comment.
@Kameshwaran why reset values even when there is an error?
|
@sachinmjadhav please make the fixes commented by @sanandnarayan |
|
@sachinmjadhav you can deprioritize this for now. i am kinda liking formspree with its spam filters. also we added chat to our website, so let this PR be open for now @Kameshwaran |
|
This PR is important for us. |
Integrated pipedrive with contact form