Skip to content

Make the sponsored guard test locale-independent #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KazenDev wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Make the sponsored guard test locale-independent #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sdk/src/__tests__/sponsored-rooted-filesystem.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ function directBroker(): TerminalCommandBroker {
start(request) {
const child = spawn(request.executable, request.args, {
cwd: request.cwd,
env: request.env,
// Pin the locale for the helper subprocess. A guard failure is asserted
// on the message coreutils prints, and coreutils translates that message
// ("El archivo ya existe"), so without this the test passes on the
// English CI runners and fails on any other locale. LC_ALL=C alone is
// enough: it takes precedence over LANG and LANGUAGE.
env: { ...request.env, LC_ALL: 'C' },
stdio: ['ignore', 'pipe', 'pipe'],
})
return {
Expand Down
Loading