Open
Conversation
…oin in Apache common
cogcomp-dev
requested changes
May 26, 2018
cogcomp-dev
left a comment
cogcomp-dev
left a comment
There was a problem hiding this comment.
Looks good & thorough -- but please add a unit test that verifies the behavior is now correct.
|
@dannima any progress on this? build is failing -- looks like a missing dependency. Also, please a unit test to verify behavior if one does not exist already (in which case, identify the test class). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to solve #593
Remove join function in utilities/StringUtils.java, use StringUtils.join in Apache common