Skip to content

9322 - n:n attributes edition in portal search pop-up hidden behind#957

Open
accognet wants to merge 2 commits into
support/3.2from
feature/9322-portal-pop-up-hidden-behind
Open

9322 - n:n attributes edition in portal search pop-up hidden behind#957
accognet wants to merge 2 commits into
support/3.2from
feature/9322-portal-pop-up-hidden-behind

Conversation

@accognet

@accognet accognet commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

internal

@accognet accognet requested a review from steffunky July 3, 2026 12:36
@accognet accognet self-assigned this Jul 3, 2026
@accognet accognet added the internal Work made by Combodo label Jul 3, 2026
@greptile-apps

greptile-apps Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adjusts portal modal stacking for nested pop-ups.

  • Reuses the current modal jQuery object in the show handler.
  • Hides tooltips before the modal opens.
  • Raises the new modal above any already visible modal with a higher z-index.
  • Applies the matching z-index to the new backdrop.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The opening modal is not visible during Bootstrap's show event, so the visible-modal scan should only account for already open modals.
  • Non-numeric modal z-index values do not appear to enter the parseInt branch in this comparison.

Important Files Changed

Filename Overview
datamodels/2.x/itop-portal-base/portal/public/js/bootstrap-portal-modal.js Updates the modal show handler to compute stacking from currently visible modals and apply the matching backdrop layer.

Reviews (1): Last reviewed commit: "N°9322 - n:n attributes edition in porta..." | Re-trigger Greptile

@accognet accognet changed the base branch from develop to support/3.2 July 3, 2026 12:39

@steffunky steffunky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be ported ton 3.2 new look (https://github.com/Combodo/itop-portal-new-look-for-3.2-lts/blob/master/public/js/bootstrap-portal-modal.js).
I think this will require a new bug ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants