Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Dec 30, 2025

┆Issue is synchronized with this Notion page by Unito

Copilot AI review requested due to automatic review settings December 30, 2025 06:15
@benceruleanlu benceruleanlu requested a review from a team as a code owner December 30, 2025 06:15
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 30, 2025
@benceruleanlu benceruleanlu merged commit 6dc7ad0 into main Dec 30, 2025
11 of 12 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The pull request modifies the frontend build process in an optional branch by adding the COREPACK_ENABLE_STRICT: '0' environment variable to pnpm install and pnpm run build commands, while preserving the existing DISTRIBUTION: 'desktop' variable.

Changes

Cohort / File(s) Summary
Frontend build environment configuration
scripts/downloadFrontend.js
Adds COREPACK_ENABLE_STRICT: '0' environment variable to pnpm install and pnpm run build commands in the optional-branch build step

Possibly related PRs

  • Switch FE npm to pnpm #1502: Modifies the same optional-branch frontend build steps in scripts/downloadFrontend.js to change pnpm invocation method and environment configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benceruleanlu benceruleanlu deleted the bl-successive-pig branch December 30, 2025 06:15
@dosubot dosubot bot added the bug Something isn't working label Dec 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the todesktop workflow by disabling strict corepack mode when building the frontend from an optional branch. The change adds the COREPACK_ENABLE_STRICT: '0' environment variable to both the pnpm install and pnpm run build commands.

  • Added COREPACK_ENABLE_STRICT: '0' environment variable to pnpm commands when building from optional branch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants