Conversation
Closed
Gunoshozo
force-pushed
the
EFFWave
branch
5 times, most recently
from
8467787 to
f409fbe
Compare
Gunoshozo
force-pushed
the
EFFWave
branch
5 times, most recently
from
ec046ec to
edfcd7f
Compare
PringlesGang
approved these changes
Apr 1, 2026
KKhanhH
approved these changes
Apr 2, 2026
- Reorder some stuff in Wave methods, to make less unnecessary calculations - Add minimal support for alpha ScrWork of wave effect from newer versions of an engine - Add default log to the InstBGeffectWave, to catch newer versions of instruction
- Character2D::Render Moved out a loop invariant - Renderer::InsertVertices unite 2 passes over the same vector + fix possible side effect of using restart indices - Renderer::DrawPrimitives preallocate TransformedVertices and use spans of it + branch on sheet.IsScreenCap to std::transform or std::copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EFFWave Effect
Rendering Hot Path Optimizations