Ditch hooks on generic methods, replace a delegate instead#23
Merged
bigkahuna443 merged 1 commit intoCommunalHelper:devfrom Feb 21, 2025
Merged
Ditch hooks on generic methods, replace a delegate instead#23bigkahuna443 merged 1 commit intoCommunalHelper:devfrom
bigkahuna443 merged 1 commit intoCommunalHelper:devfrom
Conversation
Collaborator
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Such hooks have been causing trouble recently when trying to update MonoMod in Everest because it has started to actively look for those and block them. Fortunately here it looks like the same behaviour can be re-implemented through replacing a delegate and capturing the old one.
I have not extensively tested this but it seems like it does work.