add an app test for discovery

[pinges]

This PR adds an app test for discovery. The test allows the number of nodes to be created an the number of expected connections to be changed. The checked in version creates 10 nodes and expects every node to have 9 connections.
The test checks that each node has the expected connections and also checks that the EL nodes start syncing.

---

Note

Adds a 10-node discovery integration test and refactors peer scoring tests for stability; also logs ENR updates in discovery service.

• Integration Tests (app):
  • Discovery: New MaruDiscoveryTest spins up N Besu/Maru nodes, uses node 0 as bootnode, verifies peer discovery via ENR and EL block sync (defaults: 10 nodes, expect 9 peers each).
  • Peer Scoring: MaruPeerScoringTest refactored for robustness:
    • Simplifies setup/teardown; replaces manual ports with p2pPort=0u/discoveryPort=0u; removes coroutine tx loop and unused mocks.
    • Uses await-based checks, clearer assertions, and ensures clients start/sync before assertions.
    • Adjusts timeouts/cooldowns; logs validator ENR.
• P2P:
  • MaruDiscoveryService: add info log on local node record updates including enr.

^{Written by Cursor Bugbot for commit 3b16325. This will update automatically on new commits. Configure here.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (a597f9a) to head (3b16325).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #423      +/-   ##
============================================
+ Coverage     83.26%   83.48%   +0.21%     
- Complexity     1111     1126      +15     
============================================
  Files           226      228       +2     
  Lines          8003     8072      +69     
  Branches        624      628       +4     
============================================
+ Hits           6664     6739      +75     
+ Misses         1000      996       -4     
+ Partials        339      337       -2     

Flag	Coverage Δ
kotlin	83.48% <100.00%> (+0.21%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jonesho]

LGTM

[cursor]

Bug: Unsynced Peers Break Network Connection Tests

The removal of awaitTillMaruHasPeers(1u) calls for both validator and follower nodes means the tests proceed without ensuring the Maru nodes have established P2P connections. The peer scoring tests explicitly check peer counts and disconnection behavior, which requires nodes to be connected first. Without this synchronization, tests may check peer counts before connections are established, causing flaky failures or incorrect test behavior.

 

[fluentcrafter]

I will oppose every new usage of findPorts by default, because this pattern feels wrong. In real world, ports are either set to 0 and assigned by the OS or a specific port number reserved for a certain instance ahead of time. And findPorts is trying to do the work that is supposed to be done by the OS.

What happened to your very strong opposition stated here ?

[Filter94]

Nothing. Thanks for keeping my integrity in check!

[fluentcrafter]

Please favour logfmt and string template

Suggested change

	log.info("Node record updated. $newRecord")
	log.info("updated enr={}", newRecord)

[Filter94]

That's not ENR, but yes, we should stick with logfmt. Let me change that