Skip to content

Options modal resets saved settings when reopened/closed #350

Description

@Titas-Ghosh

Hi @pradeeban ,
I've identified a data persistence bug in the concore-editor where the Options modal unintentionally overwrites current settings with hardcoded defaults.
Currently, the modal initializes to empty values (e.g., false or "") instead of pulling from the superState. Since the modal dispatches SET_OPTIONS upon closing, simply opening and closing the window even without user input, wipes out existing configurations for Docker, Octave, and critical parameters like maxTime. This creates significant onboarding friction for anyone who need their environment settings to remain persistent.

The Options modal should be "state aware." On open, all fields should prefill with values currently stored in the superState, closing should only update values if the user has explicitly modified them. i think the main cause of this issue might be that the OptionsModal local state is not (synced) from the superState when the modal is triggered.

to fix this , i am thinking of implementing a synchronization step when superState.optionsModal is active, before user interaction, the local state should be populated with the current superState values to ensure configuration integrity.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions