feat: Extract non-custodial signers setup to allow from the SDK initialization. #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now, instead of initializing the non-custodial signer stack when the SDK is initialized, we are allowing the developer to start it only for a given view.
For instance, in the EVM demo app, the
TransferDashboardViewnow has:That will only require the SDK (which can be used as it is now with the environment variable or any other method) and the state that determines the sheet's appearance.
There is a convenience method in case the sheet is the selected option to render the custom view that will handle the callback:
This is how the EVM demo app looks after these changes:
signing-otp.mp4
Disclaimer.
These changes to the EVM demo app make the message signing in the
BalanceDashboardViewunusable because the email signer is not allowed for that.