Skip to content

Commit f9cb927

Browse files
committed
Alternative approach for pagebreak_in_banner
1 parent 4397dd2 commit f9cb927

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

R/tex-table.R

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,11 @@ latexTableBody <- function(df, theme, question_alias = NULL) {
195195
rows <- apply(cbind(rownames(dt), dt), 1, paste, collapse = " & ")
196196
}
197197
# Add a newline to each row, then join in a single string
198-
return(paste(rows, newline, collapse = "\n"))
198+
if(!theme$pagebreak_in_banner) {
199+
return(paste(rows, "\\\\*", collapse = "\n"))
200+
} else {
201+
return(paste(rows, newline, collapse = "\n"))
202+
}
199203
})
200204

201205
# Assemble the components of the table, based on "data_order"
@@ -275,9 +279,9 @@ tableHeader.CrossTabVar <- function(var, theme) {
275279
}
276280

277281
nopagebreak <- NULL
278-
if (!theme$pagebreak_in_banner) {
279-
nopagebreak <- "\\begin{absolutelynopagebreak}"
280-
}
282+
# if (!theme$pagebreak_in_banner) {
283+
# nopagebreak <- "\\begin{absolutelynopagebreak}"
284+
# }
281285

282286
header <- paste(
283287
nopagebreak,

R/writeLatex.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,13 +222,13 @@ latexReportTables <- function(results, banner, theme) {
222222
# bottomrule gets wiped out by nopagebreak environment
223223
# adding one manually
224224
if (!theme$pagebreak_in_banner) {
225-
table = gsub(
225+
table <- gsub(
226226
"\\end{longtable}",
227-
"\\bottomrule\\end{longtable}\n\\end{absolutelynopagebreak}",
227+
"\\bottomrule\\end{longtable}\n", # \\end{absolutelynopagebreak}",
228228
table, fixed = TRUE)
229-
# table <- noBreaks(table)
230229
}
231230

231+
232232
table_bodies[[i]] <- table
233233
}
234234

tests/testthat/test-write-latex.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,9 @@ test_that("Adds nonTabBookSummary as expected", {
201201

202202
res <- latexReportTables(results, NULL, tema)
203203

204-
# Expect absolutelynopagebreak wraps on all
204+
# Expect absolutelynopagebreak wraps on none!
205205
expect_true(
206-
all(grepl("absolutelynopagebreak", res))
206+
all(!grepl("absolutelynopagebreak", res))
207207
)
208208

209209
# Clear page not appended to results

0 commit comments

Comments
 (0)