fix: Update for pgmonitor-extension 2.1. disable all default collectors in postgres_exporter #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update pgMontior for changes in pgmonitor-extension 2.1.0. New metrics for sql_exporter and update alerts.
The options currently used in the example sysconfig files for postgres_exporter to disable the default metrics to not disable the new collectors that have been getting added. This hadn't been a problem until PG17 when the builtin bgwriter query broke. We do not use any of the built in metrics, so disable all the collectors in our example. Note this is not an issue in sql_exporter since it has no default DB metrics.
Found that some metrics for pgbouncer_fdw had been misnamed in the sql_exporter collector file. Renamed them to match what they were in postgres_exporer and to also match what the Grafana dashboard is expecting
Fixed an errant double-quote in the sql_exporter pgbouncer fdw metrics file
Please indicate what kind of change your PR includes (multiple selections are acceptable):
PRs should be against existing issues, so please list each issue using a separate 'closes' line:
closes #456 #398
If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.
depends on #
If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.
Testing
None of the testing listed below is optional.
Code testing
Have you tested your changes against:
If your code touches sql_exporter, have you:
If your code touches node_exporter, have you:
If your code touches Prometheus, have you:
promtool check configpromtool check rulesIf your code touches Grafana, have you:
Checklist: