Skip to content

Conversation

@keithf4
Copy link
Collaborator

@keithf4 keithf4 commented Feb 14, 2025

Description

Update pgMontior for changes in pgmonitor-extension 2.1.0. New metrics for sql_exporter and update alerts.

The options currently used in the example sysconfig files for postgres_exporter to disable the default metrics to not disable the new collectors that have been getting added. This hadn't been a problem until PG17 when the builtin bgwriter query broke. We do not use any of the built in metrics, so disable all the collectors in our example. Note this is not an issue in sql_exporter since it has no default DB metrics.

Found that some metrics for pgbouncer_fdw had been misnamed in the sql_exporter collector file. Renamed them to match what they were in postgres_exporer and to also match what the Grafana dashboard is expecting

Fixed an errant double-quote in the sql_exporter pgbouncer fdw metrics file

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #456 #398

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

depends on #

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • Not applicable

If your code touches sql_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4 keithf4 added the BUG Something isn't working label Feb 14, 2025
@keithf4 keithf4 added this to the 5.2 milestone Feb 14, 2025
@keithf4 keithf4 self-assigned this Feb 14, 2025
Co-authored-by: Douglas J Hunley <[email protected]>
@hunleyd hunleyd self-requested a review February 26, 2025 14:30
hunleyd
hunleyd previously approved these changes Feb 26, 2025
jchancojr
jchancojr previously approved these changes Feb 28, 2025
@keithf4 keithf4 requested a review from hunleyd February 28, 2025 16:12
@keithf4 keithf4 changed the title fix: disable all default collectors in postgres_exporter fix: Update for pgmonitor-extension 2.1. disable all default collectors in postgres_exporter Feb 28, 2025
@keithf4 keithf4 merged commit cc0b597 into CrunchyData:development Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BUG Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable all collectors with postgres_exporter

4 participants