Skip to content

Conversation

@keithf4
Copy link
Collaborator

@keithf4 keithf4 commented Apr 17, 2025

Description

Correct the column name change in show databases for reserve_pool to reserve_pool_size. Create a new collection file for pgbouncer 1.24+ that has that change

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #464

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

depends on #

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version: 5.2
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • Not applicable

If your code touches sql_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4 keithf4 self-assigned this Apr 17, 2025
@keithf4 keithf4 added this to the 5.2 milestone Apr 17, 2025
hunleyd
hunleyd previously approved these changes Apr 17, 2025
YorviArias
YorviArias previously approved these changes Apr 21, 2025
hunleyd
hunleyd previously approved these changes Apr 21, 2025
@keithf4 keithf4 dismissed stale reviews from hunleyd and YorviArias via 1f7eefb April 21, 2025 14:50
@keithf4 keithf4 requested review from YorviArias and hunleyd April 21, 2025 14:50
@keithf4 keithf4 merged commit 4ba5868 into CrunchyData:development Apr 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support pgbouncer 1.24 reserve pool change

4 participants