Skip to content

Conversation

@dsessler7
Copy link
Contributor

@dsessler7 dsessler7 commented May 22, 2025

…v5.2.1 metrics.

Update other containers dashboards to use ccp metrics and maintain compatibility with postgres_exporter metrics. Add pgBouncer dashboard.
Ignore pgBouncer in non-pgBouncer dashboards.

Description

Please fill this template out fully; failure to do so can result in rejection of your PR.

Please describe the changes made by your PR. This description should be at a high-level but detailed enough that a reviewer understands the scope of the fix or enhancement and can easily judge the PRs validity at addressing the stated issue/feature. Please fully describe any new or changed feature and whether said change is user-facing or not:

The OpenTelemetry metrics feature in CPK is designed to use the latest available ccp metrics in pgMonitor. This PR updates the containers dashboards to use the metrics while also maintaining compatibility with postgres_exporter metrics. This PR also adds a pgBouncer dedicated dashboard and ignores pgBouncer pods in other non-pgBouncer specific dashboards.

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #469

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

N/A

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other: CPK
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • Not applicable

If your code touches sql_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

keithf4
keithf4 previously approved these changes May 23, 2025
@benjaminjb
Copy link
Contributor

@dsessler7 are there any changes that need to be made to the monitoring_installers repo for the v5.2.1 update?

hunleyd
hunleyd previously approved these changes May 23, 2025
@dsessler7
Copy link
Contributor Author

@keithf4 @hunleyd, I see a check failed for lack of a changelog fragment... Do you need me to add one? If so, can you provide some guidance on that and any other documentation changes needed?

…v5.2.1 metrics.

Update other containers dashboards to use ccp metrics and maintain compatibility with postgres_exporter metrics.
Add pgBouncer dashboard.
Ignore pgBouncer in non-pgBouncer dashboards.
@dsessler7 dsessler7 dismissed stale reviews from hunleyd and keithf4 via 1bf5620 May 23, 2025 18:41
@dsessler7 dsessler7 force-pushed the update-containers-dashboards-5.2.1 branch from 3609d96 to 1bf5620 Compare May 23, 2025 18:41
@dsessler7
Copy link
Contributor Author

Nevermind, I found the changelogs README and added one. Hope that suffices... However it looks like I need another approval.

@dsessler7 dsessler7 requested review from hunleyd and keithf4 May 23, 2025 18:42
@keithf4 keithf4 merged commit 29e6386 into CrunchyData:development May 28, 2025
1 check passed
@dsessler7 dsessler7 deleted the update-containers-dashboards-5.2.1 branch May 28, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update containers dashboards to use latest ccp metrics and maintain compatibility with postgres_exporter metrics.

4 participants