Skip to content

Conversation

@keithf4
Copy link
Collaborator

@keithf4 keithf4 commented Jun 27, 2025

Description

Removed pg_settings_checksum metric

Removed support for PostgreSQL 11 & 12

Consolidated setup file to single file since it's now common across all PG versions

Please indicate what kind of change your PR includes (multiple selections are acceptable):

  • Bugfix
  • Enhancement
  • Breaking Change
  • Documentation

PRs should be against existing issues, so please list each issue using a separate 'closes' line:

closes #467

If this PR depends on another PR or resolution of another issue, please indicate that here using a separate 'depends' line for each dependency.

depends on #

If you have an external dependency (packages, portal updates, etc), add the 'BLOCKED' tag to your PR.

Testing

None of the testing listed below is optional.

  • Installation method:
    • Binary install from source, version:
    • OS package repository, distro, and version:
    • Local package server, version:
    • Custom-built package, version:
    • Other:
  • PostgreSQL, Specify version(s):
  • docs tested with hugo version(s):

Code testing

Have you tested your changes against:

  • RedHat/CentOS
  • Ubuntu
  • Not applicable

If your code touches sql_exporter, have you:

  • Tested against all versions of PostgreSQL affected
  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches node_exporter, have you:

  • Ensure that exporter runs with no scrape errors
  • Not applicable

If your code touches Prometheus, have you:

  • Ensured all configuration changes pass promtool check config
  • Ensured all alert rule changes pass promtool check rules
  • Prometheus runs without issue
  • Alertmanager runs without issue
  • Not applicable

If your code touches Grafana, have you:

  • Ensured Grafana runs without issue
  • Ensured relevant dashboards load without issue
  • Not applicable

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@keithf4 keithf4 self-assigned this Jun 27, 2025
@keithf4 keithf4 changed the title Github467 remove pg_settings checksum feature. drop old PG versions Jun 27, 2025
Co-authored-by: Douglas J Hunley <[email protected]>
@keithf4 keithf4 requested a review from hunleyd June 30, 2025 14:51
hunleyd
hunleyd previously approved these changes Jun 30, 2025
YorviArias
YorviArias previously approved these changes Jul 7, 2025
@keithf4 keithf4 dismissed stale reviews from YorviArias and hunleyd via db62360 July 9, 2025 17:42
@keithf4 keithf4 requested review from YorviArias and hunleyd July 9, 2025 17:42
@keithf4 keithf4 merged commit 390935a into CrunchyData:development Jul 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PG Settings Checksum feature does not work as expected

4 participants