Conversation
jhkang1517
requested changes
Mar 4, 2024
jhkang1517
left a comment
jhkang1517
left a comment
Collaborator
There was a problem hiding this comment.
.exposedHeaders("*") 와 시연 설정만 원복하면 될 것 같습니다! 🦾
| .allowedOriginPatterns("*") // 모든 도메인에 대해 액세스 허용 | ||
| .allowedMethods("GET", "POST", "PUT", "PATCH", "DELETE", "OPTIONS") // 허용할 HTTP 메서드 | ||
| .allowedHeaders("*") // 모든 헤더 허용 | ||
| .exposedHeaders("*") |
Collaborator
There was a problem hiding this comment.
실제 header 값인 access token 과 refresh token , re-access token 등으로 변경하면 좋을 것 같습니다! 😄
Reference
| jwt: | ||
| secret-key: ${jwt-secret-key} | ||
| access-duration-mils: 1800000 | ||
| access-duration-mils: 21600000 |
Collaborator
There was a problem hiding this comment.
시연용 설정은 원복해서 다시 배포하는 것이 좋을 것 같습니다! 🎡
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
작업 내용
이 PR은 다음과 같은 작업을 포함하고 있습니다:
변경 사항
다음과 같은 파일/부분을 수정했습니다:
src/main/kotlin/mara/server/domain/�share/ShareRepository.kt: findAllMyShare 쿼리문 조건 and 에서 or 로 변경테스트
다음과 같은 테스트를 수행했습니다: