Skip to content

GIDINET: support init command#4288

Merged
TomOnTime merged 4 commits into
mainfrom
gidinet-register-creds-metadata
May 27, 2026
Merged

GIDINET: support init command#4288
TomOnTime merged 4 commits into
mainfrom
gidinet-register-creds-metadata

Conversation

@TomOnTime
Copy link
Copy Markdown
Collaborator

Summary

Register CredsMetadata for GIDINET so the provider is offered by the dnscontrol init wizard.

Fields mirror the entries in integrationTest/profiles.json.

CC: @zupolgec

Test plan

  • go build ./... passes
  • dnscontrol init lists GIDINET as an option
  • Verify any // TODO: Verify annotations in the diff (e.g. PortalURL)

🤖 Generated with Claude Code

Register CredsMetadata so the GIDINET provider appears in the `dnscontrol init` wizard.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@zupolgec zupolgec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomOnTime ! Builds clean, tests pass, and dnscontrol init lists GIDINET. One correction to the creds metadata, plus a related docs fix.

Creds metadata — see the inline suggestion. Gidinet doesn't authenticate with the control-panel login: the username is the normal account username, but the password must be the dedicated "API password" generated at https://www.gidinet.com/modules/private/account_password/. The suggestion resolves the // TODO: Verify on PortalURL (it's .com, and points right at the API-password page), adds a Notes line, and clarifies the field labels/help.

Docsdocumentation/provider/gidinet.md isn't in this PR, but its Activation section currently claims the credentials "are the same ones you use to log in to the control panel," which is wrong for the password. Worth fixing in the same PR. Suggested replacement for that section:

## Activation

1. Log in to the [Gidinet Control Panel](https://www.gidinet.com/)
2. Generate an **API password** at [https://www.gidinet.com/modules/private/account_password/](https://www.gidinet.com/modules/private/account_password/)
3. In `creds.json`, use your account **username** together with that **API password** — the API password is distinct from your normal login password

Comment thread providers/gidinet/gidinetProvider.go Outdated
@TomOnTime TomOnTime requested a review from cafferata as a code owner May 27, 2026 13:08
@TomOnTime
Copy link
Copy Markdown
Collaborator Author

Thanks! I've updated the documentation.

@TomOnTime
Copy link
Copy Markdown
Collaborator Author

Imma merge this so that it gets into the new release. We can fix any docs in an separate PR.

@TomOnTime TomOnTime merged commit 5154617 into main May 27, 2026
26 checks passed
@TomOnTime TomOnTime deleted the gidinet-register-creds-metadata branch May 27, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants